Skip to content

Add CanAdminsBypass to CreateUpdateEnvironment#2727

Merged
gmlewis merged 3 commits into
google:masterfrom
jvm986:add_can_admins_bypass_to_create_update_environment
Mar 30, 2023
Merged

Add CanAdminsBypass to CreateUpdateEnvironment#2727
gmlewis merged 3 commits into
google:masterfrom
jvm986:add_can_admins_bypass_to_create_update_environment

Conversation

@jvm986
Copy link
Copy Markdown
Contributor

@jvm986 jvm986 commented Mar 29, 2023

Addresses #2725

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2023

Codecov Report

Merging #2727 (1973bc4) into master (6bba7a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2727   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         131      131           
  Lines       11463    11466    +3     
=======================================
+ Hits        11237    11240    +3     
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/repos_environments.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jvm986 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 29, 2023
@cbrgm
Copy link
Copy Markdown
Contributor

cbrgm commented Mar 30, 2023

Good job @jvm986 and thanks for your fast response @gmlewis !

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Mar 30, 2023

@cbrgm - can you please give an LGTM+Approval?

Copy link
Copy Markdown
Contributor

@cbrgm cbrgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Mar 30, 2023

Thank you, @cbrgm !
Merging.

@gmlewis gmlewis merged commit 78c5d00 into google:master Mar 30, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants